Add documentation about reloading search analyzers #42865
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
>docs
Collaborator
|
Pinging @elastic/es-search |
jimczi
reviewed
Jun 5, 2019
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
Thanks @cbuescher . I left some comments.
| @@ -0,0 +1,56 @@ | |||
| [[indices-reload-analyzers]] | |||
Contributor
There was a problem hiding this comment.
This should be marked as experimental.
| Using the <<analyzer reload API,indices-reload-analyzers>>, you can trigger reloading of the | ||
| synonym definition. The contents of the configured synonyms file will be reloaded and the | ||
| synonyms definition the filter uses will be updated. Note that if you trying to use the above | ||
| analyzer as an index analyzer will result in an error. |
Contributor
There was a problem hiding this comment.
I would extract the last sentence in a NOTE in order to make sure that users are aware of the limitation.
| <2> Synonym filter is usable as a search_analyzer. | ||
|
|
||
| Calling the `_reload_search_analyzers` endpoint will now trigger reloading the | ||
| synonyms from the configured "synonym.txt" file. |
Contributor
There was a problem hiding this comment.
Maybe add a NOTE regarding the fact that the reload is per node so you need to update your synonym.txt file on every node before calling reload.
Member
Author
|
@jimczi I will also reopen this against the new feature branch I had to create and address your comments there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation to the feature being worked on in #42669